Shorten mapreduce by using Ops.reduce #858
Draft
+168
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like CI fails badly when integrating to mapreduce. I have to work more on it. |
avik-pal
reviewed
Mar 8, 2025
Comment on lines
-552
to
-561
| if dims != (:) | ||
| red = Ops.reshape(TracedRArray(red), toonedims...) | ||
| else | ||
| if length(outdims) == 0 | ||
| red = TracedRNumber{redT}((), red) | ||
| else | ||
| red = TracedRArray{redT,length(outdims)}((), red, (outdims...,)) | ||
| end | ||
| end | ||
| return red |
There was a problem hiding this comment.
these checks need to be preserved to ensure that the final result matches julia semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From PR #840, the mapreduce() can be changed to call the Ops.reduce().
I found that I have to change the function signature by taking the
@nonspecialize(f)out and substitute with (somewhat ugly?)f::Fto force the Julia's compiler to recompile this function every time the new anonymous function for map is introduced to the function call i.e., what is in the test cases. Otherwise, there will be the world age issue.I'm not so sure where to put the test in, so put it in
ops.jl